[PATCH v2 1/3] mm/mmu_notifier: use structure for invalidate_range_start/end callback

[Jerome Glisse]

On Thu, Dec 06, 2018 at 08:30:27PM -0700, Jason Gunthorpe wrote:
> On Wed, Dec 05, 2018 at 12:36:26AM -0500, jglisse at redhat.com wrote:
> > From: Jérôme Glisse <jglisse at redhat.com>
> > 
> > To avoid having to change many callback definition everytime we want
> > to add a parameter use a structure to group all parameters for the
> > mmu_notifier invalidate_range_start/end callback. No functional changes
> > with this patch.
> > 
> > Signed-off-by: Jérôme Glisse <jglisse at redhat.com>
> > Cc: Andrew Morton <akpm at linux-foundation.org>
> > Cc: Matthew Wilcox <mawilcox at microsoft.com>
> > Cc: Ross Zwisler <zwisler at kernel.org>
> > Cc: Jan Kara <jack at suse.cz>
> > Cc: Dan Williams <dan.j.williams at intel.com>
> > Cc: Paolo Bonzini <pbonzini at redhat.com>
> > Cc: Radim Krčmář <rkrcmar at redhat.com>
> > Cc: Michal Hocko <mhocko at kernel.org>
> > Cc: Christian Koenig <christian.koenig at amd.com>
> > Cc: Felix Kuehling <felix.kuehling at amd.com>
> > Cc: Ralph Campbell <rcampbell at nvidia.com>
> > Cc: John Hubbard <jhubbard at nvidia.com>
> > Cc: kvm at vger.kernel.org
> > Cc: dri-devel at lists.freedesktop.org
> > Cc: linux-rdma at vger.kernel.org
> > Cc: linux-fsdevel at vger.kernel.org
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c  | 43 +++++++++++--------------
> >  drivers/gpu/drm/i915/i915_gem_userptr.c | 14 ++++----
> >  drivers/gpu/drm/radeon/radeon_mn.c      | 16 ++++-----
> >  drivers/infiniband/core/umem_odp.c      | 20 +++++-------
> >  drivers/infiniband/hw/hfi1/mmu_rb.c     | 13 +++-----
> >  drivers/misc/mic/scif/scif_dma.c        | 11 ++-----
> >  drivers/misc/sgi-gru/grutlbpurge.c      | 14 ++++----
> >  drivers/xen/gntdev.c                    | 12 +++----
> >  include/linux/mmu_notifier.h            | 14 +++++---
> >  mm/hmm.c                                | 23 ++++++-------
> >  mm/mmu_notifier.c                       | 21 ++++++++++--
> >  virt/kvm/kvm_main.c                     | 14 +++-----
> >  12 files changed, 102 insertions(+), 113 deletions(-)
> 
> The changes to drivers/infiniband look mechanical and fine to me.
> 
> It even looks like this avoids merge conflicts with the other changes
> to these files :)
> 
> For infiniband:
> 
> Acked-by: Jason Gunthorpe <jgg at mellanox.com>
> 
> I assume this will go through the mm tree?

Yes this is my exceptation as in the ends it touch more mm
stuff than anything else. Andrew already added v1 to its
patchset.

Cheers,
Jérôme