[PATCH 10/29] drm/omap: Remove omap_dss_device dst field

[Sebastian Reichel]

Hi,

On Wed, Dec 05, 2018 at 05:00:03PM +0200, Laurent Pinchart wrote:
> The field is only used in a safety check during device
> connection/disconnection, where the src field can be easily used
> instead. Remove it and use src.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel at collabora.com>

-- Sebastian

>  drivers/gpu/drm/omapdrm/dss/base.c    | 6 ++----
>  drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 -
>  2 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/base.c b/drivers/gpu/drm/omapdrm/dss/base.c
> index 61a231d2fef3..8454e505b282 100644
> --- a/drivers/gpu/drm/omapdrm/dss/base.c
> +++ b/drivers/gpu/drm/omapdrm/dss/base.c
> @@ -210,9 +210,8 @@ int omapdss_device_connect(struct dss_device *dss,
>  	}
>  
>  	if (src) {
> -		WARN_ON(src->dst);
> +		WARN_ON(dst->src);
>  		dst->src = src;
> -		src->dst = dst;
>  	}
>  
>  	return 0;
> @@ -230,11 +229,10 @@ void omapdss_device_disconnect(struct omap_dss_device *src,
>  	}
>  
>  	if (src) {
> -		if (WARN_ON(dst != src->dst))
> +		if (WARN_ON(dst->src != src))
>  			return;
>  
>  		dst->src = NULL;
> -		src->dst = NULL;
>  	}
>  
>  	WARN_ON(dst->state != OMAP_DSS_DISPLAY_DISABLED);
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index 4c0980999576..28e24d65f211 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -411,7 +411,6 @@ struct omap_dss_device {
>  
>  	struct dss_device *dss;
>  	struct omap_dss_device *src;
> -	struct omap_dss_device *dst;
>  	struct omap_dss_device *next;
>  
>  	struct list_head list;
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20181209/55b40697/attachment-0001.sig>