[PATCH 16/29] drm/omap: Don't pass display pointer to encoder init function

[Sebastian Reichel]

Hi,

On Wed, Dec 05, 2018 at 05:00:09PM +0200, Laurent Pinchart wrote:
> The display isn't used by the encoder implementation, don't pass it to
> the initialization function and store it internally needlessly.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel at collabora.com>

-- Sebastian

>  drivers/gpu/drm/omapdrm/omap_drv.c     | 2 +-
>  drivers/gpu/drm/omapdrm/omap_encoder.c | 5 +----
>  drivers/gpu/drm/omapdrm/omap_encoder.h | 3 +--
>  3 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 66c4cedb5539..286590657d44 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -296,7 +296,7 @@ static int omap_modeset_init(struct drm_device *dev)
>  		struct drm_encoder *encoder;
>  		struct drm_crtc *crtc;
>  
> -		encoder = omap_encoder_init(dev, pipe->output, display);
> +		encoder = omap_encoder_init(dev, pipe->output);
>  		if (!encoder)
>  			return -ENOMEM;
>  
> diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c b/drivers/gpu/drm/omapdrm/omap_encoder.c
> index 5765e3ae5b16..79ee927cd905 100644
> --- a/drivers/gpu/drm/omapdrm/omap_encoder.c
> +++ b/drivers/gpu/drm/omapdrm/omap_encoder.c
> @@ -37,7 +37,6 @@
>  struct omap_encoder {
>  	struct drm_encoder base;
>  	struct omap_dss_device *output;
> -	struct omap_dss_device *display;
>  };
>  
>  static void omap_encoder_destroy(struct drm_encoder *encoder)
> @@ -239,8 +238,7 @@ static const struct drm_encoder_helper_funcs omap_encoder_helper_funcs = {
>  
>  /* initialize encoder */
>  struct drm_encoder *omap_encoder_init(struct drm_device *dev,
> -				      struct omap_dss_device *output,
> -				      struct omap_dss_device *display)
> +				      struct omap_dss_device *output)
>  {
>  	struct drm_encoder *encoder = NULL;
>  	struct omap_encoder *omap_encoder;
> @@ -250,7 +248,6 @@ struct drm_encoder *omap_encoder_init(struct drm_device *dev,
>  		goto fail;
>  
>  	omap_encoder->output = output;
> -	omap_encoder->display = display;
>  
>  	encoder = &omap_encoder->base;
>  
> diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.h b/drivers/gpu/drm/omapdrm/omap_encoder.h
> index a7b5dde63ecb..4aefb3142886 100644
> --- a/drivers/gpu/drm/omapdrm/omap_encoder.h
> +++ b/drivers/gpu/drm/omapdrm/omap_encoder.h
> @@ -25,7 +25,6 @@ struct drm_encoder;
>  struct omap_dss_device;
>  
>  struct drm_encoder *omap_encoder_init(struct drm_device *dev,
> -				      struct omap_dss_device *output,
> -				      struct omap_dss_device *display);
> +				      struct omap_dss_device *output);
>  
>  #endif /* __OMAPDRM_ENCODER_H__ */
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20181209/71d6e592/attachment-0001.sig>