[PATCH 24/29] drm/omap: Factor out common mode validation code

Sebastian Reichel sebastian.reichel at collabora.com
Mon Dec 10 13:16:47 UTC 2018


Hi Laurent,

On Mon, Dec 10, 2018 at 10:27:05AM +0200, Laurent Pinchart wrote:
> On Monday, 10 December 2018 00:19:22 EET Sebastian Reichel wrote:
> > On Wed, Dec 05, 2018 at 05:00:17PM +0200, Laurent Pinchart wrote:
> > > The encoder .atomic_check() and connector .mode_valid() operations both
> > > walk through the dss devices in the pipeline to validate the mode.
> > > Factor out the common code in a new omap_drm_connector_mode_fixup()
> > > function.
> > > 
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > > ---
> > 
> > This is a bit tricky to review. It would probably be easier to
> > review, if the changes were split into two commits:
> > 
> > 1. introduce common function
> > 2. move drm_display_mode/videomode conversion further up the stack
> 
> I agree that the connector changes are not very nicely formatted. I however 
> don't like splitting patches, especially when small, in such a way.
> 
> One issue preventing a better diff formatting is the change from int to enum 
> drm_mode_status for the omap_connector_mode_valid() function. Without that 
> change, the patch can be better formatted with
> 
> git diff --anchored="static int omap_connector_mode_valid"
> 
> I agree it's still not perfect.
> 
> If you think the above change is worth it I'll submit a split version, 
> otherwise I'll leave it as is.

You don't have to change it for me. I just asked for better
formating in future patches.

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20181210/c33d8508/attachment-0001.sig>


More information about the dri-devel mailing list