[PATCH] host1x: cdma: use completion instead of semaphore

Arnd Bergmann arnd at arndb.de
Tue Dec 11 10:11:38 UTC 2018


On Tue, Dec 11, 2018 at 11:08 AM Thierry Reding
<thierry.reding at gmail.com> wrote:
>
> On Mon, Dec 10, 2018 at 10:51:04PM +0100, Arnd Bergmann wrote:
> > In this usage, the two are completely equivalent, but the
> > completion documents better what is going on, and we generally
> > try to avoid semaphores these days.
> >
> > Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> > ---
> >  drivers/gpu/host1x/cdma.c | 6 +++---
> >  drivers/gpu/host1x/cdma.h | 4 ++--
> >  2 files changed, 5 insertions(+), 5 deletions(-)
>
> My understanding is that potentially many userspace processes could be
> blocking on this, which I think is the reason for it being a semaphore.
> Is the completion going to work for those cases as well?

Yes, it behaves the exact same way here.

       Arnd


More information about the dri-devel mailing list