[PATCH] dts: rockchip: rk3066: add qos_hdmi and HCLK_HDMI to pmu node

[Tomasz Figa]

Hi Johan,

On Sun, Dec 16, 2018 at 12:03 AM Johan Jonker <jbx9999 at hotmail.com> wrote:
>
> A MK808 TV stick with rk3066 processor boots normal with logo and console.
> After the boot the monitor remains black.
> This patch fixes a vblank timeout crash by adding qos_hdmi and
> HCLK_HDMI to the pmu node.
> The HCLK_HDMI clock and the RK3066_PD_VIO power domain
> will now turn on and off together.
>
> Signed-off-by: Johan Jonker <jbx9999 at hotmail.com>
> ---
>  arch/arm/boot/dts/rk3066a.dtsi | 6 ++++--
>  arch/arm/boot/dts/rk3xxx.dtsi  | 5 +++++
>  2 files changed, 9 insertions(+), 2 deletions(-)
>

Thanks for the patch. Unfortunately, it looks like you didn't add the
necessary mailing lists to the recipient list. For reference, the
./scripts/get_maintainer.pl script in the kernel source tree should be
able to give you a reasonable recipient list. For now, I added the
mailing lists on CC and replied without snipping, so people should be
still able to review the patch.

Other than that, It looks reasonable to me, but we need someone with
access to SoC documentation to check it. Heiko, Sandy, is that
something you would be able to help with?

> diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi
> index 30dc8af0b..6e7cdde84 100644
> --- a/arch/arm/boot/dts/rk3066a.dtsi
> +++ b/arch/arm/boot/dts/rk3066a.dtsi
> @@ -672,13 +672,15 @@
>                                  <&cru ACLK_IPP>,
>                                  <&cru HCLK_IPP>,
>                                  <&cru ACLK_RGA>,
> -                                <&cru HCLK_RGA>;
> +                                <&cru HCLK_RGA>,
> +                                <&cru HCLK_HDMI>;
>                         pm_qos = <&qos_lcdc0>,
>                                  <&qos_lcdc1>,
>                                  <&qos_cif0>,
>                                  <&qos_cif1>,
>                                  <&qos_ipp>,
> -                                <&qos_rga>;
> +                                <&qos_rga>,
> +                                <&qos_hdmi>;
>                 };
>
>                 pd_video at RK3066_PD_VIDEO {
> diff --git a/arch/arm/boot/dts/rk3xxx.dtsi b/arch/arm/boot/dts/rk3xxx.dtsi
> index 97307a405..1f9496e81 100644
> --- a/arch/arm/boot/dts/rk3xxx.dtsi
> +++ b/arch/arm/boot/dts/rk3xxx.dtsi
> @@ -187,6 +187,11 @@
>                 reg = <0x1012f280 0x20>;
>         };
>
> +       qos_hdmi: qos at 1012f300 {
> +               compatible = "syscon";
> +               reg = <0x1012f300 0x20>;
> +       };
> +

Is this really common for all rk3xxx SoCs?

>         usb_otg: usb at 10180000 {
>                 compatible = "rockchip,rk3066-usb", "snps,dwc2";
>                 reg = <0x10180000 0x40000>;
> --
> 2.11.0
>

Best regards,
Tomasz