[PATCH v2 -next] staging: fbtft: use strcmp() instead of strncmp() for
Dan Carpenter
dan.carpenter at oracle.com
Tue Dec 18 13:37:47 UTC 2018
On Tue, Dec 18, 2018 at 09:25:08PM +0800, YueHaibing wrote:
> strncmp() stops comparing when either the end of one of the first two
> arguments is reached or when 'n' characters have been compared, whichever
> comes first.That means that strncmp(s1, s2, n) is equivalent to
> strcmp(s1, s2) if n exceeds the length of s1 or the length of s2.
>
> This patch avoids that the following warning is reported by smatch:
>
> drivers/staging/fbtft/fbtft_device.c:1458
> fbtft_device_init() error: strncmp() '"list"' too small (5 vs 32)
>
> Signed-off-by: YueHaibing <yuehaibing at huawei.com>
> ---
> v2: fix patch title
v2 is worse than v1...
v1 is a little long but I wouldn't have complained about it.
Please assume that the subject and the commit message are separate
things. Take a look how the patch description reads on marc.info:
https://marc.info/?l=linux-driver-devel&m=154513957719226&w=2
regards,
dan carpenter
More information about the dri-devel
mailing list