[Bug 109060] android-x86 64bit builds crashes due to android/gralloc_handle.h

[Robert Foss]

Hey Chih-Wei & Mauro,

This fix looks good to me.
Cleaned up patch name and pushed to repo.


Rob.

On 2018-12-14 01:05, bugzilla-daemon at freedesktop.org wrote:
> Bug ID 	109060 <https://bugs.freedesktop.org/show_bug.cgi?id=109060>
> Summary 	android-x86 64bit builds crashes due to android/gralloc_handle.h
> Product 	DRI
> Version 	DRI git
> Hardware 	x86-64 (AMD64)
> OS 	other
> Status 	NEW
> Severity 	blocker
> Priority 	medium
> Component 	libdrm
> Assignee 	dri-devel at lists.freedesktop.org
> Reporter 	issor.oruam at gmail.com
> 
> Createdattachment 142809 <attachment.cgi?id=142809> [details] 
> <attachment.cgi?id=142809&action=edit>  [review]  <page.cgi?id=splinter.html&bug=109060&attachment=142809>
> draft patch that solves the crashes
> 
> Hi,
> there is a series of Android apps using 32bit libs on 64bit Android that are
> crashing (Jackpal terminal, Sky Force, Olympus Rising, Vulkan V1, 3dmark
> benchmarks and many others)
> 
> The cause is the difference in size of gralloc handle structs created by 32bit
> libraries and 64bit architetures libraries.
> 
> The problem was observed and patched in gbm_gralloc in the past by Chih-Wei
> Huang, but it was not taken into account in later evolution,
> now with android/gralloc_handle.h in libdrm the problem is again present,
> because the handle sizes in 32bit and 64bit are again different.
> 
> The attached draft patch solves the issue, tested on all apps that were
> crashing
> Please review and provide feedback
> 
> Mauro
> 
> --------------------------------------------------------------------------------
> You are receiving this mail because:
> 
>   * You are the assignee for the bug.
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>