[PATCH] drm: add missing flags to DRM_MODE_FLAG_ALL

Ville Syrjälä ville.syrjala at linux.intel.com
Wed Dec 19 14:33:01 UTC 2018


On Wed, Dec 19, 2018 at 01:42:41PM +0000, emersion wrote:
> I guess DRM_MODE_FLAG_PIC_AR_MASK has been overlooked.

Nope. We don't hang on to the aspect ratio flags internally
and they get wiped before we check against DRM_MODE_FLAG_ALL.
Not sure this makes any sense really, but that's how it is atm.

> 
> Signed-off-by: Simon Ser <contact at emersion.fr>
> ---
>  include/uapi/drm/drm_mode.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> index d3e0fe31efc..b8d5226c8e5 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -128,7 +128,8 @@ extern "C" {
>  				 DRM_MODE_FLAG_HSKEW |		\
>  				 DRM_MODE_FLAG_DBLCLK |		\
>  				 DRM_MODE_FLAG_CLKDIV2 |	\
> -				 DRM_MODE_FLAG_3D_MASK)
> +				 DRM_MODE_FLAG_3D_MASK |	\
> +				 DRM_MODE_FLAG_PIC_AR_MASK)
>  
>  /* DPMS flags */
>  /* bit compatible with the xorg definitions. */
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel


More information about the dri-devel mailing list