[PATCH 0/3] drm: tweak permission handling

[Daniel Vetter]

On Wed, Dec 19, 2018 at 09:30:46PM +0100, Daniel Vetter wrote:
> On Wed, Dec 19, 2018 at 07:22:44PM +0000, Emil Velikov wrote:
> > Hi all,
> > 
> > This series relaxes some permission handling we have in core.
> > 
> > The first patch, swaps the DRM_ROOT_ONLY to DRM_MASTER on DROP_MASTER
> > ioctls. Thus any application can drop privileges just after SET_MASTER
> > and not worry about elevating them, solely for DROP_MASTER.
> > 
> > The last commit, admittedly works around userspace bugs. Although it's
> > far better than the "run as root" approach that people have been using.
> > 
> > It has the extra side effect of allowing some userspace (but not all)
> > to use vgem without any modifications ;-)
> > 
> > Would be great if this series is checked through the Intel GFX trybot
> > but I'm not sure how to do that.
> 
> Just cc intel-gfx at lists.freedesktop.org.

Even better would be a few igts to exercise this stuff. We have some basic
auth tests, but not much, so running this through the intel CI won't test
much at all.
-Daniel

> -Daniel
> 
> > 
> > Any comments, review or general ack's are appreciated.
> > 
> > Thanks
> > Emil
> > 
> > Emil Velikov (3):
> >   drm: change DROP_MASTER permissions to allow DRM_MASTER
> >   drm: annotate drm_core_check_feature() dev arg. as const
> >   drm: allow render capable master with DRM_AUTH ioctls
> > 
> >  drivers/gpu/drm/drm_ioctl.c | 10 +++++++---
> >  include/drm/drm_drv.h       |  2 +-
> >  2 files changed, 8 insertions(+), 4 deletions(-)
> > 
> > -- 
> > 2.19.2
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch