[PATCH 2/7] drm: omapdrm: Cleanup drm_display_mode print str

Sebastian Reichel sre at kernel.org
Wed Dec 19 21:41:38 UTC 2018


Hi,

Tomi is neither in To, nor in Cc of this patch?

On Wed, Dec 19, 2018 at 07:22:04PM -0200, Shayenne Moura wrote:
> This patch adjust the print string of drm_display_mode object
> to remove drm_mode_object dependency in omapdrm files.
> 
> Signed-off-by: Shayenne Moura <shayenneluzmoura at gmail.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel at collabora.com>

-- Sebastian

>  drivers/gpu/drm/omapdrm/omap_connector.c | 9 ++-------
>  drivers/gpu/drm/omapdrm/omap_crtc.c      | 8 ++------
>  2 files changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c b/drivers/gpu/drm/omapdrm/omap_connector.c
> index b81302c4bf9e..874d8f3cbff6 100644
> --- a/drivers/gpu/drm/omapdrm/omap_connector.c
> +++ b/drivers/gpu/drm/omapdrm/omap_connector.c
> @@ -305,14 +305,9 @@ static int omap_connector_mode_valid(struct drm_connector *connector,
>  	drm_mode_destroy(dev, new_mode);
>  
>  done:
> -	DBG("connector: mode %s: "
> -			"%d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
> +	DBG("connector: mode %s: " DRM_MODE_FMT,
>  			(ret == MODE_OK) ? "valid" : "invalid",
> -			mode->base.id, mode->name, mode->vrefresh, mode->clock,
> -			mode->hdisplay, mode->hsync_start,
> -			mode->hsync_end, mode->htotal,
> -			mode->vdisplay, mode->vsync_start,
> -			mode->vsync_end, mode->vtotal, mode->type, mode->flags);
> +			DRM_MODE_ARG(mode));
>  
>  	return ret;
>  }
> diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdrm/omap_crtc.c
> index caffc547ef97..40acf4ce7c9f 100644
> --- a/drivers/gpu/drm/omapdrm/omap_crtc.c
> +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c
> @@ -427,12 +427,8 @@ static void omap_crtc_mode_set_nofb(struct drm_crtc *crtc)
>  	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
>  	struct drm_display_mode *mode = &crtc->state->adjusted_mode;
>  
> -	DBG("%s: set mode: %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
> -	    omap_crtc->name, mode->base.id, mode->name,
> -	    mode->vrefresh, mode->clock,
> -	    mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal,
> -	    mode->vdisplay, mode->vsync_start, mode->vsync_end, mode->vtotal,
> -	    mode->type, mode->flags);
> +	DBG("%s: set mode: " DRM_MODE_FMT,
> +	    omap_crtc->name, DRM_MODE_ARG(mode));
>  
>  	drm_display_mode_to_videomode(mode, &omap_crtc->vm);
>  }
> -- 
> 2.17.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20181219/a698fa2f/attachment.sig>


More information about the dri-devel mailing list