[PATCH] drm/msm/gpu: fix bo size for msm_rbmemptrs

Chia-I Wu olvaffe at gmail.com
Fri Dec 21 00:10:52 UTC 2018


Ah, thanks.  I was on drm-next branch.  I will switch to msm-next.

On Thu, Dec 20, 2018 at 11:47 AM Jordan Crouse <jcrouse at codeaurora.org>
wrote:

> On Thu, Dec 20, 2018 at 10:47:02AM -0800, Chia-I Wu wrote:
> > memptrs_bo is used to store msm_rbmemptrs.  Size it correctly.
> >
> > Signed-off-by: Chia-I Wu <olvaffe at gmail.com>
>
> Thanks for your patch. I'm really glad somebody is looking seriously at
> this
> code.  We have this in msm-next:
>
>
> https://cgit.freedesktop.org/~robclark/linux/commit/?h=msm-next&id=546ec7b471bcae78463426a218b8c7f35bbb71f4
>
> I think that might fix your concern?
>
> Jordan
>
> > ---
> >  drivers/gpu/drm/msm/msm_gpu.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/msm/msm_gpu.c
> b/drivers/gpu/drm/msm/msm_gpu.c
> > index 11aac8337066..d23049eb29c4 100644
> > --- a/drivers/gpu/drm/msm/msm_gpu.c
> > +++ b/drivers/gpu/drm/msm/msm_gpu.c
> > @@ -917,7 +917,7 @@ int msm_gpu_init(struct drm_device *drm, struct
> platform_device *pdev,
> >               goto fail;
> >       }
> >
> > -     memptrs = msm_gem_kernel_new(drm, sizeof(*gpu->memptrs_bo),
> > +     memptrs = msm_gem_kernel_new(drm, sizeof(struct msm_rbmemptrs) *
> nr_rings,
> >               MSM_BO_UNCACHED, gpu->aspace, &gpu->memptrs_bo,
> >               &memptrs_iova);
> >
> > --
> > 2.18.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20181220/4b45b382/attachment.html>


More information about the dri-devel mailing list