[PATCH 6/6] drm/i915: drop all drmP.h includes

Jani Nikula jani.nikula at intel.com
Thu Dec 27 16:27:53 UTC 2018


On Thu, 27 Dec 2018, Daniel Vetter <daniel at ffwll.ch> wrote:
> I guess next up would be to split up i915_drv.h and intel_drv.h and see
> how much our driver is a spaghetti mess where everything needs everything
> else :-)

In general this got me wondering how self-contained the header files
really need to be. Turns out even <linux/kernel.h> isn't self-contained,
it fails on do_div() for my config if <asm/div64.h> isn't included some
other route. Didn't dig deep, but by the looks of it this is not a new
breakage (if you can call it that).

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the dri-devel mailing list