[PATCH] drm/panel: Fix ARM Versatile panel clocks

[Linus Walleij]

On Thu, Feb 8, 2018 at 11:50 AM, Eric Anholt <eric at anholt.net> wrote:

>> -                     .clock = 625000000,
>> +                     .clock = 625000,
>
> 625000kHz still seems really suspicious.

Right, an order of magnitude typo on my part :(
It is even correct in the fbdev driver.

I sent a v2 fixing it.

>  The fbdev driver does:
>
>         clk_set_rate(fb->clk, (1000000000 / regs.pixclock) * 1000);
>
> which seems really strange to me -- set the clock rate lower as pixclock
> increases?  What's going on here?

That is regs.pixclock from struct clcd_regs in <linux/amba/clcd.h>,
i.e. the register value of the pixel clock, not the mode info.
So it makes sense: calculates the frequency in Hz and set that
to the clock (the AUX oscillator, as this driver is not even making
use of the clock divider).

Yours,
Linus Walleij