[PATCH] drm/rockchip: Don't use spin_lock_irqsave in interrupt context
Marc Zyngier
marc.zyngier at arm.com
Mon Feb 12 09:28:41 UTC 2018
Hi Heiko,
On 10/02/18 16:23, Heiko Stuebner wrote:
> Hi Marc,
>
> Am Samstag, 10. Februar 2018, 15:35:01 CET schrieb Marc Zyngier:
>> The rockchip DRM driver is quite careful to disable interrupts
>> when taking a lock that is also taken in interrupt context,
>> which is a good thing.
>>
>> What is a bit over the top is to use spin_lock_irqsave when
>> already in interrupt context, as you cannot take another
>> interrupt again, and disabling interrupt is just pure
>> overhead.
>>
>> Switching to the non _irqsave version in interrupt context is
>> more logical, and less heavy handed.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier at arm.com>
>
> please note, that we had a maintainer swap for the Rockchip drm-component,
> where Sandy replaced Mark [0] ... with me acting as sort-of (and not yet
> up to speed) backup.
>
> So I guess Rockchip drm patches should also include
> Sandy Huang <hjc at rock-chips.com>
I guess that update didn't make it into 4.15, which is why I didn't spot
it. I'll repost the patches shortly including Sandy on Cc.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
More information about the dri-devel
mailing list