[PATCH v2 3/4] drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem
Daniel Vetter
daniel at ffwll.ch
Mon Feb 19 12:01:35 UTC 2018
On Mon, Feb 12, 2018 at 02:51:43PM -0500, Joe Moriarty wrote:
> The Parfait (version 2.1.0) static code analysis tool found the
> following NULL pointer derefernce problem.
>
> - drivers/gpu/drm/drm_edid.c
> The call to drm_cvt_mode() in function drm_mode_std() for the
> HDTV hack resulted in the possibility of accessing a NULL pointer
> if drm_mode_std() returned NULL. A check for this added right after
> the call to drm_cvt_mode() in this particular area of code.
>
> Signed-off-by: Joe Moriarty <joe.moriarty at oracle.com>
> Reviewed-by: Steven Sistare <steven.sistare at oracle.com>
Applied to drm-misc-next, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_edid.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index ddd537914575..23c9977d8999 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -2083,6 +2083,8 @@ drm_mode_std(struct drm_connector *connector, struct edid *edid,
> if (hsize == 1366 && vsize == 768 && vrefresh_rate == 60) {
> mode = drm_cvt_mode(dev, 1366, 768, vrefresh_rate, 0, 0,
> false);
> + if (!mode)
> + return NULL;
> mode->hdisplay = 1366;
> mode->hsync_start = mode->hsync_start - 1;
> mode->hsync_end = mode->hsync_end - 1;
> --
> 2.15.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
More information about the dri-devel
mailing list