[PATCH v5 4/5] drm: xlnx: DRM KMS driver for Xilinx ZynqMP DisplayPort

[Laurent Pinchart]

Hi Hyun,

Thank you for the patch.

On Wednesday, 7 February 2018 03:36:39 EET Hyun Kwon wrote:
> This driver creates DRM encoder and connector for ZynqMP DisplayPort.
> 
> Signed-off-by: Hyun Kwon <hyun.kwon at xilinx.com>
> Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Before I go and review the code, shouldn't this be implemented as a drm_bridge 
driver ?

> ---
> v2
> - Change the SPDX identifier format
> - Split drm properties into a separate patch
> ---
> ---
>  drivers/gpu/drm/xlnx/zynqmp_dp.c | 1738 +++++++++++++++++++++++++++++++++++
>  drivers/gpu/drm/xlnx/zynqmp_dp.h |   37 +
>  2 files changed, 1775 insertions(+)
>  create mode 100644 drivers/gpu/drm/xlnx/zynqmp_dp.c
>  create mode 100644 drivers/gpu/drm/xlnx/zynqmp_dp.h

[snip]

-- 
Regards,

Laurent Pinchart