[PATCH libdrm v2] *-symbol-check: Don't hard-code nm executable
Eric Engestrom
eric.engestrom at imgtec.com
Fri Feb 23 15:02:44 UTC 2018
On Friday, 2018-02-23 00:25:27 +0000, Emil Velikov wrote:
> On 19 February 2018 at 16:35, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> > From: Heiko Becker <heirecka at exherbo.org>
> >
> > Helpful if your nm executable has a prefix based on the
> > architecture, for example.
> >
>
> > +env_test = environment()
> > +env_test.set('NM', find_program('nm').path())
> > +
> Everything else is great, just not too sure about this hunk.
> Are you sure it does what the commit message says?
It does, I even asked the meson devs to be sure. find_program()
respects the crossfile, unless `native: true` is added [2].
>
> I know meson needs special configuration file for cross compilation -
> one example where nm has prefix.
> Yet the manual [1] does not say anything about nm. I cannot find any
> instances of nm in the docs all together :-\
There's nothing special about `nm` here, it's just a program that can be
set via the crossfile, like `cc` or `ar`.
I guess the documentation on the cross-compilation page [1] could be
improved to make the behaviour of find_program() more explicit; care to
send a patch? :)
>
> If Meson does not handle it currently, please open a bug and add a
> comment with the bug number/link.
>
> Thanks
> Emil
> [1] http://mesonbuild.com/Cross-compilation.html
[2] http://mesonbuild.com/Reference-manual.html#find_program
More information about the dri-devel
mailing list