[PATCH 22/24] drm/omap: fix maximum sizes

[Tomi Valkeinen]

On 27/02/18 15:42, Laurent Pinchart wrote:

>> +	/*
>> +	 * Note: these values are used for multiple independent things:
>> +	 * connector mode filtering, buffer sizes, crtc sizes...
>> +	 * Use big enough values here to cover all use cases, and do more
>> +	 * specific checking in the respective code paths.
>>  	 */
>> -	dev->mode_config.max_width = 2048;
>> -	dev->mode_config.max_height = 2048;
>> +	dev->mode_config.max_width = 8192;
>> +	dev->mode_config.max_height = 8192;
> 
> This makes me ponder on the usefulness of the max_width and max_height fields. 
> If we end up having to set them to very large values so they don't get in the 
> way, and implement independent checks manually, the fields should then be 
> split into finer-grained parameters to make DRM core checks useful.

I agree.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki