[drm_hwcomposer] [PATCH] Update external connectors list

Robert Foss robert.foss at collabora.com
Mon Jan 8 13:45:58 UTC 2018


Hey Mauro,

This patch looks good to me apart from the commit message formatting.
If you tell me I can add your SOB, I'll merge it with the below commit message.

On 1/6/18 12:59 AM, Mauro Rossi wrote:
 > DVID, DVII and VGA are required by discrete and integrated GPUs

I would expect something like:

Update external connectors list

VID, DVII and VGA are required by discrete and integrated GPUs.

Signed-off-by: Mauro Rossi <Mauro Rossi <issor.oruam at gmail.com>>

 > ---
 >   drmconnector.cpp | 4 +++-
 >   1 file changed, 3 insertions(+), 1 deletion(-)
 >
 > diff --git a/drmconnector.cpp b/drmconnector.cpp
 > index 247f56b..145518f 100644
 > --- a/drmconnector.cpp
 > +++ b/drmconnector.cpp
 > @@ -73,7 +73,9 @@ bool DrmConnector::internal() const {
 >   }
 >
 >   bool DrmConnector::external() const {
 > -  return type_ == DRM_MODE_CONNECTOR_HDMIA;
 > +  return type_ == DRM_MODE_CONNECTOR_HDMIA || type_ == 
DRM_MODE_CONNECTOR_DisplayPort ||
 > +         type_ == DRM_MODE_CONNECTOR_DVID || type_ == DRM_MODE_CONNECTOR_DVII ||
 > +         type_ == DRM_MODE_CONNECTOR_VGA;
 >   }
 >
 >   bool DrmConnector::valid_type() const {
 >


More information about the dri-devel mailing list