[Bug 103107] [CI] igt at gem_ctx_param@invalid-param-[get|set] - Failed assertion: __gem_context_get_param(fd, &arg) == -22

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=103107

--- Comment #10 from Marta Löfstedt <marta.lofstedt at intel.com> ---
I believe this issue started when the I915_CONTEXT_PARAM_PRIORITY was added.

commit ac14fbd460d0ec16e7750e40dcd8199b0ff83d0a
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue Oct 3 21:34:53 2017 +0100

    drm/i915/scheduler: Support user-defined priorities

so instead of hitting default case with -EINVAL return, in
i915_gem_context_getparam_ioctl,  I915_CONTEXT_PARAM_BANNABLE + 1 gives us
I915_CONTEXT_PARAM_PRIORITY.

So, we could just change I915_CONTEXT_PARAM_BANNABLE + 1 to
I915_CONTEXT_PARAM_PRIORITY + 1, but there is a comment in the testcase:

/* NOTE: This testcase intentionally tests for the next free parameter
 * to catch ABI extensions. Don't "fix" this testcase without adding all
 * the tests for the new param first.
 */

As strict interpretation of this gives that subtest for the missing
I915_CONTEXT_PARAM_GTT_SIZE, I915_CONTEXT_PARAM_NO_ERROR_CAPTURE,
I915_CONTEXT_PARAM_BANNABLE and I915_CONTEXT_PARAM_PRIORITY, needs to be added
before changing this test. I.e. this testcase fails because there are niot
testcases for all context params.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180111/fb628f10/attachment.html>