[PATCH] drm/panel: lvds: Handle the optional regulator case properly

Jani Nikula jani.nikula at linux.intel.com
Thu Jan 11 14:31:59 UTC 2018


On Thu, 11 Jan 2018, Laurent Pinchart <laurent.pinchart at ideasonboard.com> wrote:
> My preference, however, would be for devm_regulator_get_optional() to return 
> NULL when no regulator is present. The current implementation returns -ENODEV 
> in multiple cases, making it impossible to properly discriminate between 
> having no regulator and not being able to get the regulator due to an error.

Just a word of warning, IS_ERR(NULL) is false, and your proposed change
would apparently require quite a churn all over the kernel.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center


More information about the dri-devel mailing list