[PATCH libdrm] drm: fix return value

Daniel Vetter daniel at ffwll.ch
Wed Jan 31 08:09:02 UTC 2018


On Wed, Jan 31, 2018 at 10:49:47AM +0800, Chunming Zhou wrote:
> 
> 
> On 2018年01月17日 17:31, Daniel Vetter wrote:
> > On Wed, Jan 17, 2018 at 05:26:41PM +0800, Chunming Zhou wrote:
> > > 
> > > On 2018年01月17日 17:24, Christian König wrote:
> > > > Am 17.01.2018 um 09:53 schrieb Chunming Zhou:
> > > > > 
> > > > > On 2018年01月17日 16:21, Daniel Vetter wrote:
> > > > > > On Tue, Jan 16, 2018 at 02:01:40PM +0000, Zhou, David(ChunMing) wrote:
> > > > > > > Can your guys help me push it and last vamgr patches to upstream?
> > > > > > > My new count request for libdrm still is under pending.
> > > > > > Or hand out commmit rights? That's easier long-term imo ...
> > > > > That's not true, we need to track the commit for driver release, if
> > > > > we have no permission to push it, we often need to check the patch
> > > > > status to see if it's already in there.
> > > > > Are you admin for count request? if you are, and approve my count
> > > > > request, I greatly appreciate your approval.
> > > > David, sounds like a misunderstanding. What Daniel suggested was that
> > > > you should get commit rights, so that you can commit it yourself :)
> > > > 
> > > > But that's actually what we are already trying to do. It's just that the
> > > > account request seems to take a while.
> > > > 
> > > > If Alex hasn't already forwarded the request to the Admins please post
> > > > the link once more and I or Daniel can take care of it.
> > > https://bugs.freedesktop.org/show_bug.cgi?id=104631
> > > Michel and Alex have committed.
> > fd.o admins are drowning a bit under meltdown/spectre (and there's
> > apparently a pile more serious exploits that need to be patched asap).
> > 
> > I'd ping them next week on #freedesktop if it hasn't happened by then.
> Hi Daniel,
> 
> My account requesting still is under pending, Could you help it?
> https://bugs.freedesktop.org/show_bug.cgi?id=104631

Looks all ready for fd.o admins to take action. Perhaps ping them on
#freedesktop irc channel? I'm not an admin myself.
-Daniel


> 
> 
> Thanks in advance,
> David Zhou
> > -Daniel
> > 
> > > Thanks,
> > > David Zhou
> > > > Regards,
> > > > Christian.
> > > > 
> > > > > Regards,
> > > > > David Zhou
> > > > > > -Daniel
> > > > > > 
> > > > > > > Thanks,
> > > > > > > David Zhou
> > > > > > > 
> > > > > > > 
> > > > > > > 发自坚果 Pro
> > > > > > > 
> > > > > > > Christian K鰊ig <ckoenig.leichtzumerken at gmail.com> 于
> > > > > > > 2018年1月16日 下午4:56写道:
> > > > > > > 
> > > > > > > Apart from that a good catch and Reviewed-by: Christian König
> > > > > > > <christian.koenig at amd.com>.
> > > > > > > 
> > > > > > > Regards,
> > > > > > > Christian.
> > > > > > > 
> > > > > > > Am 16.01.2018 um 09:49 schrieb Michel Dänzer:
> > > > > > > > Moving from the amd-gfx list to dri-devel, since this
> > > > > > > > isn't amdgpu specific.
> > > > > > > > 
> > > > > > > > 
> > > > > > > > On 2018-01-16 03:54 AM, Chunming Zhou wrote:
> > > > > > > > > otherwise -ETIME is missed.
> > > > > > > > > 
> > > > > > > > > Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423
> > > > > > > > > Signed-off-by: Chunming Zhou <david1.zhou at amd.com>
> > > > > > > > > ---
> > > > > > > > >     xf86drm.c | 2 +-
> > > > > > > > >     1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > > > > > 
> > > > > > > > > diff --git a/xf86drm.c b/xf86drm.c
> > > > > > > > > index 8a327170..3881bd9f 100644
> > > > > > > > > --- a/xf86drm.c
> > > > > > > > > +++ b/xf86drm.c
> > > > > > > > > @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd,
> > > > > > > > > uint32_t *handles, unsigned num_handles,
> > > > > > > > > 
> > > > > > > > >         ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args);
> > > > > > > > >         if (ret < 0)
> > > > > > > > > -            return ret;
> > > > > > > > > +            return -errno;
> > > > > > > > > 
> > > > > > > > >         if (first_signaled)
> > > > > > > > >                 *first_signaled = args.first_signaled;
> > > > > > > > > 
> > > > > > > _______________________________________________
> > > > > > > dri-devel mailing list
> > > > > > > dri-devel at lists.freedesktop.org
> > > > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > > > > _______________________________________________
> > > > > dri-devel mailing list
> > > > > dri-devel at lists.freedesktop.org
> > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list