[PATCH v3 3/9] drm/connector: Make ->atomic_commit() optional

[Boris Brezillon]

On Mon, 2 Jul 2018 23:30:05 +0800
kbuild test robot <lkp at intel.com> wrote:

> Hi Boris,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on next-20180702]
> [cannot apply to drm/drm-next anholt/for-next robh/for-next v4.18-rc3 v4.18-rc2 v4.18-rc1 v4.18-rc3]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Boris-Brezillon/drm-vc4-Add-support-for-the-transposer-IP/20180702-211805
> config: x86_64-randconfig-x015-201826 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/gpu//drm/drm_atomic_helper.c: In function 'drm_atomic_helper_commit_writebacks':
> >> drivers/gpu//drm/drm_atomic_helper.c:1187:13: error: 'const struct drm_connector_helper_funcs' has no member named 'funcs'  
>       if (!funcs->funcs->atomic_commit)
>                 ^~
> 
> vim +1187 drivers/gpu//drm/drm_atomic_helper.c
> 
>   1175	
>   1176	static void drm_atomic_helper_commit_writebacks(struct drm_device *dev,
>   1177							struct drm_atomic_state *old_state)
>   1178	{
>   1179		struct drm_connector *connector;
>   1180		struct drm_connector_state *new_conn_state;
>   1181		int i;
>   1182	
>   1183		for_each_new_connector_in_state(old_state, connector, new_conn_state, i) {
>   1184			const struct drm_connector_helper_funcs *funcs;
>   1185	
>   1186			funcs = connector->helper_private;
> > 1187			if (!funcs->funcs->atomic_commit)

Oh, shame on me! :-)

I'll send a v4 with this build failure fixed, and this time I'll
compile-test at least. :-)

>   1188				continue;
>   1189	
>   1190			if (new_conn_state->writeback_job && new_conn_state->writeback_job->fb) {
>   1191				WARN_ON(connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK);
>   1192				funcs->atomic_commit(connector, new_conn_state);
>   1193			}
>   1194		}
>   1195	}
>   1196	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation