[PATCH V2] drm/vkms: Add vblank events simulated by hrtimers

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 5 08:25:38 UTC 2018


Quoting Daniel Vetter (2018-07-05 09:20:13)
> On Thu, Jul 05, 2018 at 12:48:43AM -0300, Rodrigo Siqueira wrote:
> > +     ktime_t current_timestamp;
> > +
> > +     hrtimer_init(&out->vblank_hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> 
> Can't we use absolute timer mode here? That avoids all the timestampt
> computations.

Where's your absolute timestamp being computed?
What's being done is recomputing what hrtimer already knows given a
relative interval. output->expires should be equivalent to
hrtimer->expires, and a lot of this code evaporates.
-Chris


More information about the dri-devel mailing list