[PATCH] drm/sun4i: tcon-top: Fix return type warning

Maxime Ripard maxime.ripard at bootlin.com
Thu Jul 12 16:49:30 UTC 2018


On Thu, Jul 12, 2018 at 10:35:08AM +0200, Daniel Vetter wrote:
> On Thu, Jul 12, 2018 at 10:08:18AM +0200, Maxime Ripard wrote:
> > When commit af11942ee44e ("drm/sun4i: tcon-top: Cleanup clock handling")
> > was merged, the error handling path of the of_property_match_string was
> > changed to take into account the fact that the returned value of that
> > function wasn't an error pointer but an error code.
> > 
> > Unfortunately, this introduced a warning since the now returned value is an
> > integer, while the sun8i_tcon_top_register_gate function should return an
> > error pointer.
> > 
> > Fix that by calling ERR_PTR.
> > 
> > Cc: Jernej Skrabec <jernej.skrabec at siol.net>
> > Cc: Chen-Yu Tsai <wens at csie.org>
> > Fixes: af11942ee44e ("drm/sun4i: tcon-top: Cleanup clock handling")
> > Reported-by: kbuild test robot <lkp at intel.com>
> > Reported-by: Stephen Rothwell <sfr at canb.auug.org.au>
> > Signed-off-by: Maxime Ripard <maxime.ripard at bootlin.com>
> 
> Matches at least the seamntics of the other returns afaics.
> 
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180712/687e6203/attachment.sig>


More information about the dri-devel mailing list