[PATCH 11/15] drm/doc: move struct drm_crtc to in-line comments

Sean Paul seanpaul at chromium.org
Fri Jul 13 15:27:43 UTC 2018


On Mon, Jul 09, 2018 at 10:40:12AM +0200, Daniel Vetter wrote:
> And clean them up a bit, as usual.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>  include/drm/drm_crtc.h | 126 +++++++++++++++++++++++++++++++----------
>  1 file changed, 97 insertions(+), 29 deletions(-)
> 
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 5afe2deb76b7..0cfc098f31d3 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h

/snip

> +
> +	/**
> +	 * @gamma_store: Gamma ramp values used by the legacy SETGAMME and

SETGAMMA

> +	 * GET_GAMMA IOCTls. Set up by calling drm_mode_crtc_set_gamma_size().

GETGAMMA


With the nits fixed,

Reviewed-by: Sean Paul <seanpaul at chromium.org>

> +	 */
>  	uint16_t *gamma_store;
>  
> -	/* if you are using the helper */
> +	/** @helper_private: mid-layer private data */
>  	const struct drm_crtc_helper_funcs *helper_private;
>  
> +	/** @properties: property tracking for this CRTC */
>  	struct drm_object_properties properties;
>  
>  	/**
> @@ -872,7 +941,6 @@ struct drm_crtc {
>  	 *
>  	 * spinlock to protect the fences in the fence_context.
>  	 */
> -
>  	spinlock_t fence_lock;
>  	/**
>  	 * @fence_seqno:
> -- 
> 2.18.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Sean Paul, Software Engineer, Google / Chromium OS


More information about the dri-devel mailing list