[PATCH] drm/imx: Remove unused field imx_drm_device.pipes
Leonard Crestez
leonard.crestez at nxp.com
Tue Jul 17 12:11:28 UTC 2018
This has been unused since commit 44b460cfe554 ("drm: imx: remove struct
imx_drm_crtc and imx_drm_crtc_helper_funcs")
Signed-off-by: Leonard Crestez <leonard.crestez at nxp.com>
---
drivers/gpu/drm/imx/imx-drm-core.c | 1 -
1 file changed, 1 deletion(-)
Looking at the imx_drm_device struct it is only used to save the
drm_atomic_helper_suspend state. It seems like this could be replaced
with drm_mode_config_helper_suspend/resume and the entire struct
removed.
The only difference between imx_drm_suspend/resume and
drm_mode_config_helper_suspend/resume is that the latter also suspends
the fb_helper. This would be an improvement, right?
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index 1d053bbefc02..7744e10f15b0 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -35,11 +35,10 @@
#define MAX_CRTC 4
struct imx_drm_device {
struct drm_device *drm;
- unsigned int pipes;
struct drm_atomic_state *state;
};
#if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION)
static int legacyfb_depth = 16;
--
2.17.1
More information about the dri-devel
mailing list