[PATCH v3 0/2] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set

Hans de Goede hdegoede at redhat.com
Thu Jul 19 11:45:24 UTC 2018


Hi,

On 19-07-18 12:15, Thomas Zimmermann wrote:
> Hi,
> 
> this is version 3 of the WARN_CONSOLE_UNLOCKED patch set. The
> macro prints a warning if the console's critical sections are
> entered without holding the console lock. This patch set allows
> to disable the warnings while debugging the console.
> 
> In the original approach, WARN_CONSOLE_UNLOCKED was disabled by
> setting ignore_console_lock_warning of type bool. As suggested by
> Petr Mladek, the new implementation is based on atomic_t and allows
> multiple threads to manipulate the warning state concurrently.
> 
> With version 3, the patch set now includes the patch for introducing
> ignore_console_lock_warning. This patch superseds all previous patches
> of the same purpose.
> 
> Best regards
> Thomas
> 
> v3:
> 	- implement ignore_console_lock_warning with atomic_t
> v2:
> 	- restore ignore_console_lock_warning if lock_fb_info() fails
> 
> Thomas Zimmermann (2):
>    console: Replace #if 0 with atomic var 'ignore_console_lock_warning'
>    fbdev/core: Disable console-lock warnings when fb.lockless_register_fb
>      is set

I just saw this version after my comment on v2 that the race there
was not really a problem.

This version is even better though :)    :

Acked-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans


More information about the dri-devel mailing list