[PATCH] drm/atomic: Check old_plane_state->crtc in drm_atomic_helper_async_check()

Eric Anholt eric at anholt.net
Mon Jul 23 17:07:35 UTC 2018


Boris Brezillon <boris.brezillon at bootlin.com> writes:

> Async plane update is supposed to work only when updating the FB or FB
> position of an already enabled plane. That does not apply to requests
> where the plane was previously disabled or assigned to a different
> CTRC.
>
> Check old_plane_state->crtc value to make sure async plane update is
> allowed.
>
> Fixes: fef9df8b5945 ("drm/atomic: initial support for asynchronous plane update")
> Signed-off-by: Boris Brezillon <boris.brezillon at bootlin.com>

I don't think any driver I've worked on would want an async flip of a
plane between CRTCs.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180723/9aae467e/attachment.sig>


More information about the dri-devel mailing list