[PATCH] drm/vkms: Fix connector leak at the module removal

Gustavo Padovan gustavo at padovan.org
Sat Jul 28 19:14:50 UTC 2018


Hi Rodrigo,

On Wed, Jul 18, 2018 at 09:40:45PM -0300, Rodrigo Siqueira wrote:
> Currently, vkms shows an error message if the following steps occur: (1)
> load vkms, (2) perform any specific operation in the vkms (e.g., run an
> IGT test), and (3) unload the module. The following error message
> emerges:
> 
> [drm:drm_mode_config_cleanup [drm]] *ERROR* connector Virtual-1 leaked!
> 
> This commit fixes this error by calling drm_atomic_helper_shutdown()
> before drm_mode_config_cleanup, which turns off the whole display
> pipeline and remove a reference related to any connector.
> 
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo at gmail.com>
> ---
>  drivers/gpu/drm/vkms/vkms_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 37aa2ef33b21..6e728b825259 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -44,6 +44,7 @@ static void vkms_release(struct drm_device *dev)
>  	struct vkms_device *vkms = container_of(dev, struct vkms_device, drm);
>  
>  	platform_device_unregister(vkms->platform);
> +	drm_atomic_helper_shutdown(&vkms->drm);
>  	drm_mode_config_cleanup(&vkms->drm);
>  	dri_dev_fini(&vkms->drm);

Patch pushed to drm-misc-next-fixes.

Gustavo



More information about the dri-devel mailing list