[PATCH] fb_omap: add gpiolib dependency
Arnd Bergmann
arnd at arndb.de
Fri Jun 1 15:10:26 UTC 2018
On Thu, May 31, 2018 at 8:04 AM, Andy Shevchenko
<andy.shevchenko at gmail.com> wrote:
> On Thu, May 31, 2018 at 12:49 AM, Arnd Bergmann <arnd at arndb.de> wrote:
>
>> drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c: In function 'hdmi_probe_of':
>> drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c:584:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration]
>> drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c: In function 'hdmi_probe_of':
>> drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:554:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration]
>
>> Rather than fixing up each one individually, this just marks all of it
>> as depending on GPIOLIB.
>
> Hmm... But the OF stuff is not part of GPIOLIB.
The underlying issue is the same though: linux/gpio.h includes a
different set of header files
depending on CONFIG_GPIOLIB being set or not. Without it, we are missing all the
indirect includes from asm-generic/gpio.h that include linux/of.h and
linux/gpio/consumer.h.
Arnd
More information about the dri-devel
mailing list