[PATCH 1/2] drm/scheduler: Rename cleanup functions.

Lucas Stach l.stach at pengutronix.de
Wed Jun 6 09:09:28 UTC 2018


Am Dienstag, den 05.06.2018, 13:02 -0400 schrieb Andrey Grodzovsky:
> Everything in the flush code path (i.e. waiting for SW queue
> to become empty) names with *_flush()
> and everything in the release code path names *_fini()
> 
> This patch also effect the amdgpu and etnaviv drivers which
> use those functions.
> 
> > Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky at amd.com>
> > Suggested-by: Christian König <christian.koenig at amd.com>
> ---
[...]
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> index 23e73c2..3dff4d0 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> @@ -140,7 +140,7 @@ static void etnaviv_postclose(struct drm_device *dev, struct drm_file *file)
> >  				gpu->lastctx = NULL;
> >  			mutex_unlock(&gpu->lock);
>  
> > -			drm_sched_entity_fini(&gpu->sched,
> > +			drm_sched_entity_destroy(&gpu->sched,
>  					      &ctx->sched_entity[i]);

Style nit: this disaligns the second row of parameters to the opening
parenthesis where it was previously aligned. I would prefer if the
second line is also changed to keep the alignment.

Acked-by: Lucas Stach <l.stach at pengutronix.de>


More information about the dri-devel mailing list