[PATCH v2 27/60] drm/omap: dss: Rename for_each_dss_dev macro to for_each_dss_display

Sebastian Reichel sre at kernel.org
Sun Jun 10 20:17:19 UTC 2018


Hi,

On Sat, May 26, 2018 at 08:24:45PM +0300, Laurent Pinchart wrote:
> The macro iterates over displays only, rename it accordingly.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel at collabora.co.uk>

-- Sebastian

>  drivers/gpu/drm/omapdrm/dss/dss.c     | 2 +-
>  drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 +-
>  drivers/gpu/drm/omapdrm/omap_drv.c    | 4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c
> index 8e7646181302..5b7613ff2f2e 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -1557,7 +1557,7 @@ static void dss_shutdown(struct platform_device *pdev)
>  
>  	DSSDBG("shutdown\n");
>  
> -	for_each_dss_dev(dssdev) {
> +	for_each_dss_display(dssdev) {
>  		if (!dssdev->driver)
>  			continue;
>  
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index 26abc09f3d4a..a6ddc881ea72 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -501,7 +501,7 @@ void omapdss_device_disconnect(struct omap_dss_device *src,
>  
>  struct omap_dss_device *omap_dss_get_device(struct omap_dss_device *dssdev);
>  void omap_dss_put_device(struct omap_dss_device *dssdev);
> -#define for_each_dss_dev(d) while ((d = omap_dss_get_next_device(d)) != NULL)
> +#define for_each_dss_display(d) while ((d = omap_dss_get_next_device(d)) != NULL)
>  struct omap_dss_device *omap_dss_get_next_device(struct omap_dss_device *from);
>  
>  int omap_dss_get_num_overlay_managers(void);
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index f1df5be198a8..21ca4002ac38 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -188,7 +188,7 @@ static int omap_connect_dssdevs(struct drm_device *ddev)
>  	if (!omapdss_stack_is_ready())
>  		return -EPROBE_DEFER;
>  
> -	for_each_dss_dev(dssdev) {
> +	for_each_dss_display(dssdev) {
>  		r = omapdss_device_connect(dssdev, NULL);
>  		if (r == -EPROBE_DEFER) {
>  			omap_dss_put_device(dssdev);
> @@ -200,7 +200,7 @@ static int omap_connect_dssdevs(struct drm_device *ddev)
>  			omap_dss_get_device(dssdev);
>  			priv->dssdevs[priv->num_dssdevs++] = dssdev;
>  			if (priv->num_dssdevs == ARRAY_SIZE(priv->dssdevs)) {
> -				/* To balance the 'for_each_dss_dev' loop */
> +				/* To balance the 'for_each_dss_display' loop */
>  				omap_dss_put_device(dssdev);
>  				break;
>  			}
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180610/b9862239/attachment.sig>


More information about the dri-devel mailing list