[PATCH 01/21] drm/omap: dss: Remove unused omap_dss_driver operations

Sebastian Reichel sre at kernel.org
Mon Jun 11 13:50:29 UTC 2018


Hi,

On Wed, Jun 06, 2018 at 12:36:30PM +0300, Laurent Pinchart wrote:
> The .probe(), .remove(), .run_test(), .get_rotate() and .set_rotate()
> omap_dss_driver operations are not used. Remove them.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel at collabora.co.uk>

-- Sebastian

>  drivers/gpu/drm/omapdrm/dss/omapdss.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index 882a2f8f7ac5..77ba8ace6795 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -429,9 +429,6 @@ struct omap_dss_device {
>  };
>  
>  struct omap_dss_driver {
> -	int (*probe)(struct omap_dss_device *);
> -	void (*remove)(struct omap_dss_device *);
> -
>  	int (*connect)(struct omap_dss_device *src,
>  		       struct omap_dss_device *dst);
>  	void (*disconnect)(struct omap_dss_device *src,
> @@ -439,7 +436,6 @@ struct omap_dss_driver {
>  
>  	int (*enable)(struct omap_dss_device *display);
>  	void (*disable)(struct omap_dss_device *display);
> -	int (*run_test)(struct omap_dss_device *display, int test);
>  
>  	int (*update)(struct omap_dss_device *dssdev,
>  			       u16 x, u16 y, u16 w, u16 h);
> @@ -448,9 +444,6 @@ struct omap_dss_driver {
>  	int (*enable_te)(struct omap_dss_device *dssdev, bool enable);
>  	int (*get_te)(struct omap_dss_device *dssdev);
>  
> -	u8 (*get_rotate)(struct omap_dss_device *dssdev);
> -	int (*set_rotate)(struct omap_dss_device *dssdev, u8 rotate);
> -
>  	bool (*get_mirror)(struct omap_dss_device *dssdev);
>  	int (*set_mirror)(struct omap_dss_device *dssdev, bool enable);
>  
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180611/95254b8f/attachment.sig>


More information about the dri-devel mailing list