[PATCH v2 46/60] drm/omap: dss: Remove duplicated parameter to dss_mgr_(dis)connect()

[Sebastian Reichel]

Hi,

On Mon, Jun 11, 2018 at 08:16:24PM +0300, Laurent Pinchart wrote:
> Hi Sebastian,
> 
> On Monday, 11 June 2018 02:48:45 EEST Sebastian Reichel wrote:
> > On Sat, May 26, 2018 at 08:25:04PM +0300, Laurent Pinchart wrote:
> > > The dss_mgr_connect() and dss_mgr_disconnect() functions take two
> > > omap_dss_device pointers as parameters, which are always set to the same
> > > value by all callers. Remove the duplicated pointer.
> > > 
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > > ---
> > > 
> > >  drivers/gpu/drm/omapdrm/dss/dpi.c     | 8 +++-----
> > >  drivers/gpu/drm/omapdrm/dss/dsi.c     | 8 +++-----
> > >  drivers/gpu/drm/omapdrm/dss/hdmi4.c   | 8 +++-----
> > >  drivers/gpu/drm/omapdrm/dss/hdmi5.c   | 8 +++-----
> > >  drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 ++----
> > >  drivers/gpu/drm/omapdrm/dss/output.c  | 9 ++++-----
> > >  drivers/gpu/drm/omapdrm/dss/sdi.c     | 8 +++-----
> > >  drivers/gpu/drm/omapdrm/dss/venc.c    | 8 +++-----
> > >  8 files changed, 24 insertions(+), 39 deletions(-)
> 
> [snip]
> 
> > > diff --git a/drivers/gpu/drm/omapdrm/dss/output.c
> > > b/drivers/gpu/drm/omapdrm/dss/output.c index 191b2e801257..2f7a019d059e
> > > 100644
> > > --- a/drivers/gpu/drm/omapdrm/dss/output.c
> > > +++ b/drivers/gpu/drm/omapdrm/dss/output.c
> > > @@ -109,18 +109,17 @@ void dss_uninstall_mgr_ops(struct dss_device *dss)
> > >  }
> > >  EXPORT_SYMBOL(dss_uninstall_mgr_ops);
> > > 
> > > -int dss_mgr_connect(struct omap_dss_device *dssdev, struct
> > > omap_dss_device *dst)
> > > +int dss_mgr_connect(struct omap_dss_device *dssdev)
> > >  {
> > >  	return dssdev->dss->mgr_ops->connect(dssdev->dss->mgr_ops_priv,
> > > -					     dssdev->dispc_channel, dst);
> > > +					     dssdev->dispc_channel, dssdev);
> > 
> > Maybe also change mgr_ops->connect, so that it only takes dssdev
> > as a parameter? Otherwise
> 
> It would make sense, but patch 60/60 in this series drops the mgr_ops->connect 
> operation completely, so I don't think it's worth changing this.

Right. I only checked a few patches ahead:

Reviewed-by: Sebastian Reichel <sebastian.reichel at collabora.co.uk>

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180611/15708e58/attachment.sig>