[PATCH] drm/mxsfb: rename driver to mxsfb-drm

Stefan Agner stefan at agner.ch
Wed Jun 13 12:38:16 UTC 2018


[adding Sascha and Bartlomiej]

On 13.06.2018 09:17, Marek Vasut wrote:
> On 06/13/2018 09:16 AM, Stefan Agner wrote:
>> On 13.06.2018 01:08, Marek Vasut wrote:
>>> On 06/12/2018 06:01 PM, Fabio Estevam wrote:
>>>> On Tue, Jun 12, 2018 at 11:35 AM, Stefan Agner <stefan at agner.ch> wrote:
>>>>
>>>>> There are two drivers for the LCDIF/MXSFB peripheral. If the DRM
>>>>> and fbdev are compiled in, the registration of the second driver
>>>>> fails:
>>>>>   mxs-dma 33000000.dma-apbh: initialized
>>>>>   mxsfb 30730000.lcdif: 30730000.lcdif supply lcd not found, using dummy regulator
>>>>>   mxsfb 30730000.lcdif: initialized
>>>>>   Error: Driver 'mxsfb' is already registered, aborting...
>>>>>
>>>>> Avoid driver name conflict with MXS fbdev driver by renaming the
>>>>> more recently added DRM driver.
>>>>>
>>>>> Signed-off-by: Stefan Agner <stefan at agner.ch>
>>>>
>>>> Yes, this driver name collision is annoying:
>>>>
>>>> Reviewed-by: Fabio Estevam <fabio.estevam at nxp.com>
>>>>
>>> Why dont we just kill the old fbdev driver instead ?
>>
>> The config is outside of my direct control, it's a distro kernel...
>>
>> Or what do you mean exactly? Send a patch to remove the fbdev driver?
> 
> Yes, remove the fbdev driver.

Hm, forcing people to use the DRM driver with fbdev emulation is
probably fine for most use cases. Currently you cannot use the fbdev
ioctrl to change modes/settings to the framebuffer which is probably the
only restriction...

It seems to me a rather extreme measure though, given we could fix the
situation rather easily.

But I am ok to remove the fbdev driver, if that is what we want.

--
Stefan


More information about the dri-devel mailing list