[Mesa-dev] [PATCH] wsi_common_display: Deal with vscan values

[Jason Ekstrand]

Before we get too happy to merge things, I ran the CTS tests and there are
some failures...  I've attached a fixup patch that fixes three bugs I found:

 1) We weren't setting planeReorderPossible at all and we were using 0
instead of VK_FALSE (they're the same but we should use the enum) for
persistentContent
 2) We weren't advertising disconnected connectors via
GetPhysicalDeviceDisplayProperties but were returning them from
GetPhysicalDeviceDisplayPlaneProperties.
 3) We weren't setting result if the condition variable failed to
initialize (thanks GCC!)
​
There is one outstanding issue that the CTS is complaining about, namely
that you can't create modes.  It tests that mode creation fails for a mode
with a zero width, height, or refresh rate and that's all fine.  It then
tries to re-create one of the modes that we've returned to it in
GetDisplayModeProperties and assumes that it will work.  We should probably
at least make sure that works by walking the list and looking for a mode
that matches the requested one and returning it.  I don't think anything
actually requires us to return a unique pointer so it can be a search
instead of a create.

--Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180614/27008fb7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fixups.patch
Type: text/x-patch
Size: 1674 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180614/27008fb7/attachment.bin>