[PATCH] drm/panel: simple: fix -Wliteral-conversion warning
Nick Desaulniers
ndesaulniers at google.com
Fri Jun 15 22:37:49 UTC 2018
Fixes commit 8cfe83419cdb ("drm/panel: simple: Add
support for KEO TX31D200VM0BAA")
drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit conversion from
'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33
[-Wliteral-conversion]
.vfront_porch = { 6, 21, 33.5 },
~ ^~~~
drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit conversion from
'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33
[-Wliteral-conversion]
.vback_porch = { 6, 21, 33.5 },
~ ^~~~
Signed-off-by: Nick Desaulniers <ndesaulniers at google.com>
---
Alternatively, should these be rounded up to 34? I'm guessing the
current behaviour (truncation) is correct since that's how the patch was
operating.
drivers/gpu/drm/panel/panel-simple.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index cbf1ab404ee7..12bcbd1dd77b 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1247,8 +1247,8 @@ static const struct display_timing koe_tx31d200vm0baa_timing = {
.hback_porch = { 16, 36, 56 },
.hsync_len = { 8, 8, 8 },
.vactive = { 480, 480, 480 },
- .vfront_porch = { 6, 21, 33.5 },
- .vback_porch = { 6, 21, 33.5 },
+ .vfront_porch = { 6, 21, 33 },
+ .vback_porch = { 6, 21, 33 },
.vsync_len = { 8, 8, 8 },
.flags = DISPLAY_FLAGS_DE_HIGH,
};
--
2.18.0.rc1.244.gcf134e6275-goog
More information about the dri-devel
mailing list