[PATCH v2 1/3] video: fbdev: Fix checkpatch warnings in goldfishfb.c

Roman Kiryanov rkir at google.com
Fri Jun 15 23:47:03 UTC 2018


Hi,

could you please confirm you received our patches? Thank you.

Regards,
Roman.
On Fri, Jun 8, 2018 at 12:11 PM <rkir at google.com> wrote:
>
> From: Roman Kiryanov <rkir at google.com>
>
> Address issues pointed by checkpatch.pl
>
> Signed-off-by: Roman Kiryanov <rkir at google.com>
> ---
> Changes in v2:
>  - Updated the commit message to include "video: fbdev:" and added a description.
>
>  drivers/video/fbdev/goldfishfb.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
> index 3b70044773b6..de29c4ff77e5 100644
> --- a/drivers/video/fbdev/goldfishfb.c
> +++ b/drivers/video/fbdev/goldfishfb.c
> @@ -124,6 +124,7 @@ static int goldfish_fb_check_var(struct fb_var_screeninfo *var,
>  static int goldfish_fb_set_par(struct fb_info *info)
>  {
>         struct goldfish_fb *fb = container_of(info, struct goldfish_fb, fb);
> +
>         if (fb->rotation != fb->fb.var.rotate) {
>                 info->fix.line_length = info->var.xres * 2;
>                 fb->rotation = fb->fb.var.rotate;
> @@ -148,13 +149,14 @@ static int goldfish_fb_pan_display(struct fb_var_screeninfo *var,
>         wait_event_timeout(fb->wait,
>                         fb->base_update_count != base_update_count, HZ / 15);
>         if (fb->base_update_count == base_update_count)
> -               pr_err("goldfish_fb_pan_display: timeout waiting for base update\n");
> +               pr_err("%s: timeout waiting for base update\n", __func__);
>         return 0;
>  }
>
>  static int goldfish_fb_blank(int blank, struct fb_info *info)
>  {
>         struct goldfish_fb *fb = container_of(info, struct goldfish_fb, fb);
> +
>         switch (blank) {
>         case FB_BLANK_NORMAL:
>                 writel(1, fb->reg_base + FB_SET_BLANK);
> --
> 2.18.0.rc1.242.g61856ae69a-goog
>


More information about the dri-devel mailing list