[PATCH 5/5] drm/rockchip: lvds: add missing of_node_put
Heiko Stübner
heiko at sntech.de
Sat Jun 16 12:24:09 UTC 2018
Hi Julia,
Am Mittwoch, 23. Mai 2018, 21:07:16 CEST schrieb Julia Lawall:
> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
>
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
>
> for_each_child_of_node(root, child) {
> ... when != of_node_put(child)
> when != e = child
> + of_node_put(child);
> ? break;
> ...
> }
> ... when != child
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>
thanks for catching this. I've added a "Fixes"-tag and
applied the patch to drm-misc-next
Thanks
Heiko
More information about the dri-devel
mailing list