[Intel-gfx] [PATCH 3/3] drm/i915: Print prop name/id when rejecting it

[Daniel Vetter]

On Mon, Jun 18, 2018 at 03:03:39PM +0300, Ville Syrjälä wrote:
> On Mon, Jun 18, 2018 at 10:53:13AM +0200, Daniel Vetter wrote:
> > On Mon, Jun 11, 2018 at 10:34:03PM +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > > 
> > > Use the '[PROP:id:name]' format I introduced for the core in the driver
> > > debug messages as well.
> > > 
> > > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> > 
> > I'm wondering whether there's not some kind of macro magic we could do,
> > but unfortunately printf style stuff is really not composable :-/ And our
> > stuff isn't important enough to warant new %p modes either ...
> 
> I should have DRM_PLANE_FMT, DRM_PLANE_ARGS(), etc. in some branch.
> Never posted that stuff because I wasn't entirely convinced it's
> all that useful. Opinions?

Yeah, not sure that's better either ... and doing a %s with a
drm_format_$obj() gives us massive headaches with leaking strings
everywhere :-)

Maybe we should just have an $obj->debug_str field that we file out when
creating the object? Also not awesome, but about the best I can come up
with.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch