[PATCH] drm/etnaviv: bring back progress check in job timeout handler

Fabio Estevam festevam at gmail.com
Wed Jun 27 16:15:58 UTC 2018


Hi Lucas,

On Wed, Jun 27, 2018 at 11:34 AM, Lucas Stach <l.stach at pengutronix.de> wrote:
> When the hangcheck handler was replaced by the DRM scheduler timeout
> handling we dropped the forward progress check, as this might allow
> clients to hog the GPU for a long time with a big job.
>
> It turns out that even reasonably well behaved clients like the
> Armada Xorg driver occasionally trip over the 500ms timeout. Bring
> back the forward progress check to get rid of the userspace regression.
>
> We would still like to fix userspace to submit smaller batches
> if possible, but that is for another day.
>
> Fixes: 6d7a20c07760 (drm/etnaviv: replace hangcheck with scheduler timeout)

Maybe you could add a Reported-by tag from Russell?

> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>

> +       /*
> +        * If the GPU managed to complete this jobs fence, the timout is

s/timout/timeout

Thanks


More information about the dri-devel mailing list