[PATCH] drm/msm/adreno: Remove VLA usage
Jordan Crouse
jcrouse at codeaurora.org
Fri Jun 29 21:19:35 UTC 2018
On Fri, Jun 29, 2018 at 10:47:31PM +0200, Arnd Bergmann wrote:
> On Fri, Jun 29, 2018 at 8:48 PM, Kees Cook <keescook at chromium.org> wrote:
> > In the quest to remove all stack VLA usage from the kernel[1], this
> > switches to using a kasprintf()ed buffer. Return paths are updated
> > to free the allocation.
> >
> > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
> >
> > Signed-off-by: Kees Cook <keescook at chromium.org>
> > ---
> > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 7 +++++--
> > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 28 +++++++++++++++++--------
> > 2 files changed, 24 insertions(+), 11 deletions(-)
>
> This seems fine, though using a fixed-length string is probably just
> as well here,
> given that the 'fwname' variable is always set to the constant string
> "a530_zap.mdt"
> at the moment, which is not very long.
We could make it fixed but since this code is only called once this
feels safer.
Jordan
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
More information about the dri-devel
mailing list