[PATCH v2 2/2] drm/panel: Add device_link from panel device to drm device

[Jyri Sarha]

On 28/02/18 20:14, Eric Anholt wrote:
> Jyri Sarha <jsarha at ti.com> writes:
> 
>> Add device_link from panel device (supplier) to drm device (consumer)
>> with DL_FLAG_AUTOREMOVE when drm_panel_attach() is called. Currently
>> the master drm driver is not protected against the attached. The
>> device_link with DL_FLAG_AUTOREMOVE should make sure the drm device is
>> unbound before the panel driver becomes unavailable.
>>
>> The device_link is removed when drm_panel_detach() is called. The
>> drm_panel_detach() should be called by the panel driver it self when
>> it is removed. Otherwise the both driver are racing to delete the same
>> link.
> 
> I think this paragraph wants to be:
> 
> The device_link is removed when drm_panel_detach() is called. The
> drm_panel_detach() should be called by the consumer DRM driver, not the
> panel driver, otherwise both drivers are racing to delete the same link.
> 
> Other than that, these patches are:
> 
> Reviewed-by: Eric Anholt <eric at anholt.net>
> 

Thanks second paragraph was indeed completely wrong. And the first -
especially the second sentence - does not make too much sense either,
but it anyway need rephrasing if I drop DL_FLAG_AUTOREMOVE.

> (though you'll probably want to wait a bit for Thierry to look at them
> too)
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki