[patch 1/1] drivers/gpu/drm/i915/intel_guc_log.c: work around gcc-4.4.4 union initializer issue

Andrew Morton akpm at linux-foundation.org
Thu Mar 8 20:45:26 UTC 2018


On Thu, 08 Mar 2018 12:06:46 +0200 Jani Nikula <jani.nikula at linux.intel.com> wrote:

> On Wed, 07 Mar 2018, akpm at linux-foundation.org wrote:
> > From: Andrew Morton <akpm at linux-foundation.org>
> > Subject: drivers/gpu/drm/i915/intel_guc_log.c: work around gcc-4.4.4 union initializer issue
> >
> > gcc-4.4.4 has problems with initalizers of anon unions.
> >
> > drivers/gpu/drm/i915/intel_guc_log.c: In function 'guc_log_control':
> > drivers/gpu/drm/i915/intel_guc_log.c:64: error: unknown field 'logging_enabled' specified in initializer
> >
> > Work around this.
> 
> Thanks for the patch, pushed to drm-intel-next-queued.
> 
> That said, how long do we have to care about old compilers? I thought we
> were converging on at the very least GCC 4.5 being required.

Yes, I've seen some talk about that and it is about time for us to do
it.  I'm not sure what stage things are at though.


More information about the dri-devel mailing list