[RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

[Daniel Stone]

Hi John,

On 8 March 2018 at 19:43, John Stultz <john.stultz at linaro.org> wrote:
> On Thu, Mar 8, 2018 at 3:10 AM, Robert Foss <robert.foss at collabora.com> wrote:
>>> @@ -76,8 +76,6 @@ uint32_t
>>> DrmGenericImporter::ConvertHalFormatToDrm(uint32_t hal_format) {
>>>         return DRM_FORMAT_ABGR8888;
>>>       case HAL_PIXEL_FORMAT_RGB_565:
>>>         return DRM_FORMAT_BGR565;
>>> -    case HAL_PIXEL_FORMAT_YV12:
>>> -      return DRM_FORMAT_YVU420;
>>
>> I'm not sure I understand the rationale for removing YVU420.
>
> Mostly its on Alexandru's suggestion, as I don't have any experience
> w/ using YVU420.  Per his suggestion, my sense was that since its a
> multi-plane format it was expected to fail with drmModeAddFB2().
>
> If that's incorrect, I'm fine with dropping this change.

drmModeAddFB2 absolutely works with multi-planar formats. I have no
idea about the internals of HWC or why multi-planar formats aren't
supported there though.

Cheers,
Daniel