[PATCH] libdrm: intel/Android.mk: Filter libdrm_intel library requirements on x86/x86_64

John Stultz john.stultz at linaro.org
Wed Mar 14 16:47:36 UTC 2018


When building AOSP after updating libdrm project to the
freedesktop/master branch, I've seen the following build errors:

external/libdrm/intel/Android.mk: error: libdrm_intel
(SHARED_LIBRARIES android-arm64) missing libpciaccess
(SHARED_LIBRARIES android-arm64) You can set
ALLOW_MISSING_DEPENDENCIES=true in your environment if this is
intentional, but that may defer real problems until later in the
build.

Using ALLOW_MISSING_DEPENDENCIES=true when building allows
things to function properly, but is not ideal.

So basically, while I'm not including the libdrm_intel package
into the build, just the fact that the Android.mk file references
libpciaccess which isn't a repo included in AOSP causes the build
failure.

So it seems we need some sort of conditional filter in the
Android.mk to skip over it if we're not building for intel.

Change-Id: I6cb51c7bb0a7d1a0ab1723b7d3f20aea38988495
Cc: Emil Velikov <emil.l.velikov at gmail.com>
Cc: Chad Versace <chad.versace at linux.intel.com>
Cc: Marissa Wall <marissaw at google.com>
Cc: Sean Paul <seanpaul at google.com>
Cc: Rob Herring <rob.herring at linaro.org>
Cc: Dan Willemsen <dwillemsen at google.com>
Cc: Tomasz Figa <tfiga at google.com>
Cc: Robert Foss <robert.foss at collabora.com>
Signed-off-by: John Stultz <john.stultz at linaro.org>
---
v2: Check for x86_64 as well
---
 intel/Android.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/intel/Android.mk b/intel/Android.mk
index 5407ff3..3f9db78 100644
--- a/intel/Android.mk
+++ b/intel/Android.mk
@@ -21,6 +21,7 @@
 # IN THE SOFTWARE.
 #
 
+ifeq ($(TARGET_ARCH),$(filter $(TARGET_ARCH),x86 x86_64))
 LOCAL_PATH := $(call my-dir)
 include $(CLEAR_VARS)
 
@@ -37,3 +38,4 @@ LOCAL_SHARED_LIBRARIES := \
 
 include $(LIBDRM_COMMON_MK)
 include $(BUILD_SHARED_LIBRARY)
+endif
-- 
2.7.4



More information about the dri-devel mailing list