[PATCH libdrm 3/4] meson,configure: always define UDEV

[Eric Engestrom]

On March 16, 2018 5:25:12 PM UTC, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 16 March 2018 at 17:12, Eric Engestrom <eric.engestrom at imgtec.com>
> wrote:
> > Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> > ---
> >  configure.ac | 2 ++
> >  meson.build  | 2 +-
> >  xf86drm.c    | 8 ++++----
> >  3 files changed, 7 insertions(+), 5 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 14baa1c87f9078f336fa..619af49726d198c5d685 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -347,6 +347,8 @@ AC_SUBST(PCIACCESS_LIBS)
> >
> >  if test "x$UDEV" = xyes; then
> >         AC_DEFINE(UDEV, 1, [Have UDEV support])
> > +else
> > +       AC_DEFINE(UDEV, 0)
> >  fi
> >
> >  AC_CANONICAL_HOST
> > diff --git a/meson.build b/meson.build
> > index 8d4d38b46ebcf75b9fb6..0fe04a1411963c70cf80 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -165,9 +165,9 @@ if _libkms != 'false'
> >    with_libkms = _libkms == 'true' or ['linux', 'freebsd',
> 'dragonfly'].contains(host_machine.system())
> >  endif
> >
> > +config.set10('UDEV', with_udev)
> This looks fine.
> 
> 
> >  if with_udev
> >    dep_udev = dependency('udev')
> > -  config.set10('UDEV', true)
> >  else
> >    dep_udev = []
> >  endif
> Does this pull udev.pc or libudev.pc?

udev.pc, which I think is libudev (not on a computer right now, too complicated to double check)

> 
> In either case the whole thing can go - see
> 0ec7252a1deba3bac78b5ba1ebd2898f6bbf0332 + parent commit.

Sure; I'll double check that this is true for meson as well, and make another patch atop this series for that next week :)

> 
> The series is
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks; I'll push it next week though :)

> 
> -Emil
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel