[PATCH libdrm 00/23] meson: fix 'auto' handling of drivers and simplify code

Eric Engestrom eric.engestrom at imgtec.com
Tue Mar 20 17:46:36 UTC 2018


First 5 patches fix a bug where $driver=auto could end up being turned
on even though a dependency (`with_atomic`) is missing.

Next 4 are turning auto=false into auto=true, which I guess might not be
what we want. I'm happy to change or drop them if people want, the
rebase would be quite easy.

Then a couple aesthetic patches because I find the code easier to read
like this; again, I can drop if people disagree.

The diffstat until then is mostly adding code, but that's about to
change:
 meson.build | 126 ++++++++++++++++++++++++++++++++++++------------------------
 1 file changed, 75 insertions(+), 51 deletions(-)

After that, I'm introducing a loop to handle all the copy/pasted code
for all the driver options, and then adding them to the list one by one
to make it easier to review and/or bisect if I mess it up.
 meson.build | 140 ++++++++++++++----------------------------------------------
 1 file changed, 31 insertions(+), 109 deletions(-)

---

Eric Engestrom (23):
  meson: don't enable libdrm_intel without atomic support
  meson: don't enable libdrm_radeon without atomic support
  meson: don't enable libdrm_amdgpu without atomic support
  meson: don't enable libdrm_nouveau without atomic support
  meson: don't enable libdrm_freedreno without atomic support
  meson: fix omap=auto detection (was always false)
  meson: fix exynos=auto detection (was always false)
  meson: fix tegra=auto detection (was always false)
  meson: fix entaviv=auto detection (was always false)
  meson: split vc4=auto logic to make it easier to read
  meson: split libkms=auto logic to make it easier to read
  meson: introduce simpler way to handle driver options
  meson: use simple option handling for intel
  meson: use simple option handling for radeon
  meson: use simple option handling for amdgpu
  meson: use simple option handling for nouveau
  meson: use simple option handling for vmwgfx
  meson: use simple option handling for omap
  meson: use simple option handling for exynos
  meson: use simple option handling for freedreno
  meson: use simple option handling for tegra
  meson: use simple option handling for vc4
  meson: use simple option handling for etnaviv

 meson.build | 120 +++++++++++++++++-------------------------------------------
 1 file changed, 33 insertions(+), 87 deletions(-)

-- 
Cheers,
  Eric



More information about the dri-devel mailing list